Skip to content

MFTF-33301: Eliminated AspectMock usage for TestObjectHandlerTest #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2021
Merged

MFTF-33301: Eliminated AspectMock usage for TestObjectHandlerTest #844

merged 1 commit into from
Aug 3, 2021

Conversation

bohdan-harniuk
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk commented Jul 4, 2021 •
edited
Loading

Description

Eliminated AspectMock usage for the \tests\unit\Magento\FunctionalTestFramework\Test\Handlers\TestObjectHandlerTest.

Fixed Issues (if relevant)

  1. [MFTF] Eliminate AspectMock from TestObjectHandlerTest (Complex!) magento2#33301: Eliminate AspectMock from TestObjectHandlerTest (Complex!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backwards-incompatible changes for tests or have related Pull Request with fixes to tests

@andrewbess andrewbess requested a review from jilu1 July 20, 2021 15:51
andrewbess
andrewbess approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Great changes ✅
Thank you for your contribution.

@bohdan-harniuk bohdan-harniuk added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 21, 2021
@andrewbess andrewbess self-assigned this Jul 22, 2021
@bohdan-harniuk
Copy link
Contributor Author

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan

@bohdan-harniuk bohdan-harniuk mentioned this pull request Jul 26, 2021
Merged
5 tasks
This was referenced Jul 26, 2021
Merged
Merged
@jilu1 jilu1 mentioned this pull request Jul 30, 2021
Merged
5 tasks
@jilu1
Copy link
Contributor

jilu1 commented Aug 3, 2021

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@jilu1
Copy link
Contributor

jilu1 commented Aug 3, 2021

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@jilu1, an error occurred during the Pull Request import.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 7033c7f into magento:develop Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@jilu1 jilu1 jilu1 approved these changes

Assignees

@andrewbess andrewbess

Labels
in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bohdan-harniuk @jilu1 @magento-engcom-team @andrewbess @magento-devops-reposync-svc